suvodeep-pyne commented on a change in pull request #5808:
URL: https://github.com/apache/incubator-pinot/pull/5808#discussion_r466773098
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/ThirdEyeDashboardApplication.java
##########
@@ -139,36 +114,11 @@ public void run(ThirdEyeDashboardConfiguration config,
Environment env)
final JerseyEnvironment jersey = env.jersey();
injector = Guice.createInjector(new ThirdEyeDashboardModule(config, env,
DAO_REGISTRY));
Stream.of(
- DetectionConfigurationResource.class,
- DatasetAutoOnboardResource.class,
- DashboardResource.class,
- CacheResource.class,
AnomalyResource.class,
- EntityManagerResource.class,
- MetricConfigResource.class,
- DatasetConfigResource.class,
- AdminResource.class,
- SummaryResource.class,
- ThirdEyeResource.class,
- DataResource.class,
- AnomaliesResource.class,
- EntityMappingResource.class,
- OnboardDatasetMetricResource.class,
- AutoOnboardResource.class,
- ConfigResource.class,
- CustomizedEventResource.class,
- AnomalyFlattenResource.class,
- UserDashboardResource.class,
- ApplicationResource.class,
- DetectionResource.class,
- DetectionAlertResource.class,
- YamlResource.class,
- SqlDataSourceResource.class,
- AlertResource.class,
- RootCauseTemplateResource.class,
- RootCauseSessionResource.class,
RootCauseMetricResource.class,
- AnomalySearchResource.class
Review comment:
Yes. I figured out that this one was added in the last couple of days.
So the problem for this PR is that since it refactors Resource classes, it
needs to be merged quickly else it has to be updated with every incoming
resource PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
