Jackie-Jiang commented on a change in pull request #5856:
URL: https://github.com/apache/incubator-pinot/pull/5856#discussion_r471651295
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/table/TableResizer.java
##########
@@ -98,14 +93,37 @@
};
}
+ /**
+ * Helper method to construct a OrderByValueExtractor based on the given
expression.
+ */
+ private OrderByValueExtractor getOrderByValueExtractor(ExpressionContext
expression) {
+ if (expression.getType() == ExpressionContext.Type.LITERAL) {
Review comment:
Order-by with literal itself does not make a lot of sense, but
post-aggregation might contain literal (e.g. `ORDER BY SUM(col1) * 2 -
SUM(col2)`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
