saileshnankani edited a comment on pull request #5911: URL: https://github.com/apache/incubator-pinot/pull/5911#issuecomment-679499350
> Overall: Thanks for getting this started. > > 1. You don't need to use version > 2. Remove all prompts. The test should be push-button. Top-level goal is to enter a single command with two commit hashes (and maybe a working dir) and it should run all the tests we have. > 3. Please use camel case instead of underscores > 4. Use shell functions when possible. Adding a function for usage() has often been useful for me, to be invoked from anywhere we see discrepancies that we think are user errors. > > High-Level command: > `compatCheck.sh olderCommit newerCommit [workingDir]` > Sub-commands that you will find useful to develop, either as functions or separate commands: > `checkoutAndBuild commitHash dirName` > `startService serviceName dirName` > `stopService serviceName dirName` > > For now, functions should be enough, we can split the files as needed later. Do you suggest that startServices/stopServices functions should be available along with control-service subcommand or is it supposed to replace it? In the case it replaces the control-service.sh file entirely, its command syntax suggests that we can't do rolling upgrade using startService/stopService as we don't pass in a specific component unlike control-service.sh ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
