snleee commented on a change in pull request #5934: URL: https://github.com/apache/incubator-pinot/pull/5934#discussion_r486009106
########## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentProcessorConfig.java ########## @@ -0,0 +1,181 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.segment.processing.framework; + +import com.google.common.base.Preconditions; +import org.apache.pinot.core.segment.processing.collector.CollectorConfig; +import org.apache.pinot.core.segment.processing.filter.RecordFilterConfig; +import org.apache.pinot.core.segment.processing.partitioner.PartitioningConfig; +import org.apache.pinot.core.segment.processing.transformer.RecordTransformerConfig; +import org.apache.pinot.spi.config.table.TableConfig; +import org.apache.pinot.spi.data.Schema; + + +/** + * Config for configuring the phases of {@link SegmentProcessorFramework} + */ +public class SegmentProcessorConfig { Review comment: One requirement for `SegmentMergeRollup` is to be able to put the custom name for the segment name (or at least need to put the prefix and the sequenced `merged_XXX_0...M` Where do you think it's the best place to configure those? Your segment framework also faces the same issue with the sequence id. So, the sequence id should be handled implicitly by the framework at least. And, we can probably add the config for the prefix. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
