Jackie-Jiang commented on a change in pull request #6008: URL: https://github.com/apache/incubator-pinot/pull/6008#discussion_r487331483
########## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/SegmentColumnarIndexCreator.java ########## @@ -78,6 +78,9 @@ public class SegmentColumnarIndexCreator implements SegmentCreator { // TODO Refactor class name to match interface name private static final Logger LOGGER = LoggerFactory.getLogger(SegmentColumnarIndexCreator.class); + // Allow at most 512 characters for the metadata property + private static final int METADATA_PROPERTY_LENGTH_LIMIT = 512; Review comment: They are independent, where the `maxLength` is configurable in the `FieldSpec` to allow ingesting long strings, but the property length limit is fixed. Also, the property length limit also applies to the BYTES column. ########## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/SegmentColumnarIndexCreator.java ########## @@ -78,6 +78,9 @@ public class SegmentColumnarIndexCreator implements SegmentCreator { // TODO Refactor class name to match interface name private static final Logger LOGGER = LoggerFactory.getLogger(SegmentColumnarIndexCreator.class); + // Allow at most 512 characters for the metadata property + private static final int METADATA_PROPERTY_LENGTH_LIMIT = 512; Review comment: They are independent, where the `maxLength` is configurable in the `FieldSpec` to allow ingesting long strings, but the property length limit is fixed. Also, the property length limit also applies to the BYTES column. ########## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/SegmentColumnarIndexCreator.java ########## @@ -78,6 +78,9 @@ public class SegmentColumnarIndexCreator implements SegmentCreator { // TODO Refactor class name to match interface name private static final Logger LOGGER = LoggerFactory.getLogger(SegmentColumnarIndexCreator.class); + // Allow at most 512 characters for the metadata property + private static final int METADATA_PROPERTY_LENGTH_LIMIT = 512; Review comment: They are independent, where the `maxLength` is configurable in the `FieldSpec` to allow ingesting long strings, but the property length limit is fixed. Also, the property length limit also applies to the BYTES column. ########## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/SegmentColumnarIndexCreator.java ########## @@ -78,6 +78,9 @@ public class SegmentColumnarIndexCreator implements SegmentCreator { // TODO Refactor class name to match interface name private static final Logger LOGGER = LoggerFactory.getLogger(SegmentColumnarIndexCreator.class); + // Allow at most 512 characters for the metadata property + private static final int METADATA_PROPERTY_LENGTH_LIMIT = 512; Review comment: They are independent, where the `maxLength` is configurable in the `FieldSpec` to allow ingesting long strings, but the property length limit is fixed. Also, the property length limit also applies to the BYTES column. ########## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/SegmentColumnarIndexCreator.java ########## @@ -78,6 +78,9 @@ public class SegmentColumnarIndexCreator implements SegmentCreator { // TODO Refactor class name to match interface name private static final Logger LOGGER = LoggerFactory.getLogger(SegmentColumnarIndexCreator.class); + // Allow at most 512 characters for the metadata property + private static final int METADATA_PROPERTY_LENGTH_LIMIT = 512; Review comment: They are independent, where the `maxLength` is configurable in the `FieldSpec` to allow ingesting long strings, but the property length limit is fixed. Also, the property length limit also applies to the BYTES column. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org