fx19880617 commented on a change in pull request #6020:
URL: https://github.com/apache/incubator-pinot/pull/6020#discussion_r496263638
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -223,6 +228,16 @@ public synchronized void start(HelixManager
helixZkManager) {
boolean caseInsensitive =
Boolean.parseBoolean(configs.get(Helix.ENABLE_CASE_INSENSITIVE_KEY)) || Boolean
.parseBoolean(configs.get(Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY));
_tableCache = new TableCache(_propertyStore, caseInsensitive);
+
+ _clusterInstanceConfigChangeListener = new
ClusterInstanceConfigChangeListener(_helixZkManager);
+ _clusterLiveInstanceChangeListener = new
ClusterLiveInstanceChangeListener(_helixDataAccessor, _keyBuilder);
+ try {
+ addConfigListeners(_clusterInstanceConfigChangeListener);
+ addLiveInstanceListeners(_clusterLiveInstanceChangeListener);
+ } catch (Exception e) {
Review comment:
shall we separate the listener register into two try-catch?
So if first one failed, the second one can still work or make something like
a delayed retry if you want to make this logic perfect :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
