chenboat commented on a change in pull request #6112:
URL: https://github.com/apache/incubator-pinot/pull/6112#discussion_r502743260
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java
##########
@@ -499,6 +499,15 @@ public SchemaBuilder addSingleValueDimension(String
dimensionName, DataType data
return this;
}
+ /**
+ * Add single value dimensionFieldSpec with maxLength and a
defaultNullValue
+ */
+ public SchemaBuilder addSingleValueDimension(String dimensionName,
DataType dataType, int maxLength,
Review comment:
the maxLength should be applicable only to String type only as discussed
earlier. You can add a Precondition Check here to make sure dataType is String.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
