npawar commented on a change in pull request #6336: URL: https://github.com/apache/incubator-pinot/pull/6336#discussion_r548252132
########## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ########## @@ -1777,6 +1779,143 @@ public int reloadSegment(String tableNameWithType, String segmentName) { return numMessagesSent; } + /** + * Resets a segment by disabling and then enabling the segment + */ + public void resetSegment(String tableNameWithType, String segmentName, long externalViewWaitTimeMs) { + IdealState idealState = getTableIdealState(tableNameWithType); + Preconditions.checkState(idealState != null, "Could not find ideal state for table: %s", tableNameWithType); + ExternalView externalView = getTableExternalView(tableNameWithType); + Preconditions.checkState(externalView != null, "Could not find external view for table: %s", tableNameWithType); + Set<String> instanceSet = idealState.getInstanceSet(segmentName); + Preconditions + .checkState(CollectionUtils.isNotEmpty(instanceSet), "Could not find segment: %s in ideal state for table: %s"); + Map<String, String> externalViewStateMap = externalView.getStateMap(segmentName); + List<String> partitions = Lists.newArrayList(segmentName); + + // First, disable or reset partition + for (String instance : instanceSet) { + if (externalViewStateMap == null || SegmentStateModel.ERROR.equals(externalViewStateMap.get(instance))) { + LOGGER.info("Resetting partition: {} of table: {}", segmentName, tableNameWithType); + _helixAdmin.resetPartition(_helixClusterName, instance, tableNameWithType, partitions); + } else { + LOGGER.info("Disabling partition: {} of table: {}", segmentName, tableNameWithType); + _helixAdmin.enablePartition(false, _helixClusterName, instance, tableNameWithType, partitions); Review comment: Did not follow your comment. That is exactly what's happening few lines below after the external view stabilizes ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org