[GitHub] [incubator-pinot] cyrilou242 opened a new pull request #6467: [TE] fix heatmap not displaying when dot in metric name

[GitBox]

cyrilou242 opened a new pull request #6467:
URL: https://github.com/apache/incubator-pinot/pull/6467


   ## Description
   In Thirdeye:
   The Bigquery datasource allows metric to contain dots in their name. eg: 
"device.browser" 
   The `.` symbol is not managed correctly in the JS code of the heatmap, 
resulting in the heatmap not being displayed for a metric containing a point.
   
   This PR fixes the problem by escaping the `.` character.
   
   Before: 
   <img width="911" alt="Capture d’écran 2021-01-19 à 16 24 43" 
src="https://user-images.githubusercontent.com/27781189/105203933-f36ee680-5b43-11eb-9902-eedac5732be1.png";>
   
   After: 
   <img width="897" alt="Capture d’écran 2021-01-20 à 16 36 52" 
src="https://user-images.githubusercontent.com/27781189/105203889-e7832480-5b43-11eb-9891-32cc040b278c.png";>
   
   
   ## Upgrade Notes
   Does this PR prevent a zero down-time upgrade? (Assume upgrade order: 
Controller, Broker, Server, Minion)
   NO
   
   Does this PR fix a zero-downtime upgrade introduced earlier?
   NO
   
   Does this PR otherwise need attention when creating release notes? Things to 
consider:
   NO


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org