Jackie-Jiang commented on a change in pull request #6515:
URL: https://github.com/apache/incubator-pinot/pull/6515#discussion_r568179873



##########
File path: 
pinot-core/src/main/java/org/apache/pinot/core/util/ListenerConfigUtil.java
##########
@@ -112,6 +112,12 @@ private ListenerConfigUtil() {
 
     listeners.addAll(buildListenerConfigs(brokerConf, "pinot.broker.client", 
tlsDefaults));
 
+    // support legacy behavior < 0.7.0
+    if (listeners.isEmpty()) {

Review comment:
       ```suggestion
     public static List<ListenerConfig> buildBrokerConfigs(PinotConfiguration 
brokerConf) {
       TlsConfig tlsDefaults = TlsUtils.extractTlsConfig(brokerConf, 
CommonConstants.Broker.BROKER_TLS_PREFIX);
       List<ListenerConfig> listeners = buildListenerConfigs(brokerConf, 
"pinot.broker.client", tlsDefaults);
       if (listeners.isEmpty()) {
         int queryPort = brokerConf.getProperty(Helix.KEY_OF_BROKER_QUERY_PORT, 
Helix.DEFAULT_BROKER_QUERY_PORT);
         listeners = Collections.singletonList(
             new ListenerConfig(CommonConstants.HTTP_PROTOCOL, DEFAULT_HOST, 
queryPort, CommonConstants.HTTP_PROTOCOL,
                 new TlsConfig()));
       }
       return listeners;
     }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to