jackjlli commented on a change in pull request #6579: URL: https://github.com/apache/incubator-pinot/pull/6579#discussion_r581661435
########## File path: pinot-spi/src/main/java/org/apache/pinot/spi/metrics/PinotTimer.java ########## @@ -0,0 +1,32 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.metrics; + +import java.util.concurrent.TimeUnit; + +/** + * A timer metric which aggregates timing durations and provides duration statistics, plus + * throughput statistics via {@link PinotMeter}. + */ +public interface PinotTimer extends PinotMetered { + + void update(long duration, TimeUnit unit); Review comment: This `update` method in Timer interface is used in recording the time span in each of the query phases. I've updated the description in the next push. There are definitely more methods than just this one but this is the only one that's being used in pinot repo. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
