mcvsubbu commented on a change in pull request #6590:
URL: https://github.com/apache/incubator-pinot/pull/6590#discussion_r582417029
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java
##########
@@ -63,6 +63,7 @@
DOCUMENTS_SCANNED("documents", false),
ENTRIES_SCANNED_IN_FILTER("documents", false),
ENTRIES_SCANNED_POST_FILTER("documents", false),
+ REQUEST_SIZE("requestSize", false),
Review comment:
This should be a gauge, not a meter.
A meter is a counter, whereas a gauge is an actual value at any point in
time.
Add the metric to BrokerGauge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
