jackjlli commented on a change in pull request #6618:
URL: https://github.com/apache/incubator-pinot/pull/6618#discussion_r585808592
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/TaskGeneratorRegistry.java
##########
@@ -43,18 +43,16 @@
private final Map<String, PinotTaskGenerator> _taskGeneratorRegistry = new
HashMap<>();
+ public static final String TASK_GENERATOR_PACKAGE_REGEX_PATTERN =
".*\\.plugin\\.minion\\.tasks\\..*";
+
/**
* Registers the task generators via reflection.
* NOTE: In order to plugin a class using reflection, the class should
include ".generator." in its class path. This
Review comment:
Javadoc here needs to be updated
##########
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/convert_to_raw_index/ConvertToRawIndexTaskExecutor.java
##########
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.pinot.minion.executor;
+package org.apache.pinot.plugin.minion.tasks.convert_to_raw_index;
Review comment:
I see. Thanks for providing the reference here. If we want to follow
this convention, it'd be good to refactor other package paths in the repo as
well. E.g.:
`org.apache.pinot.broker.requesthandler` for `BaseBrokerRequestHandler`
class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]