npawar commented on a change in pull request #6611:
URL: https://github.com/apache/incubator-pinot/pull/6611#discussion_r593465252
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/segment/uploader/SegmentUploader.java
##########
@@ -34,10 +36,17 @@
void init(TableConfig tableConfig)
throws Exception;
+ /**
+ * Uploads the segment tar file to the cluster
+ * @param segmentTarFile URI of segment tar file
+ */
+ void uploadSegment(URI segmentTarFile)
+ throws Exception;
+
/**
* Uploads the segments from the segmentDir to the cluster
- * @param segmentDir URI of segment tar file or URI of directory containing
segment tar files
+ * @param segmentDir URI of directory containing segment tar files
*/
- void upload(URI segmentDir)
+ void uploadSegments(URI segmentDir)
Review comment:
there's 2 methods. `uploadSegment` takes the segmentTarFile,
`uploadSegments` takes the segmentDir.
the wrapper class can make the call of which API to call. Potentially flush
can also make multiple segments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
