npawar commented on a change in pull request #6718:
URL: https://github.com/apache/incubator-pinot/pull/6718#discussion_r604306507
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/batch/BatchConfigProperties.java
##########
@@ -42,7 +42,11 @@
public static final String SCHEMA_URI = "schemaURI";
public static final String SEQUENCE_ID = "sequenceId";
public static final String SEGMENT_NAME_GENERATOR_TYPE =
"segmentNameGenerator.type";
- public static final String SEGMENT_NAME_GENERATOR_CONFIGS =
"segmentNameGenerator.configs";
+ public static final String SEGMENT_NAME_GENERATOR_PROP_PREFIX =
"segmentNameGenerator.configs";
+ public static final String SEGMENT_NAME = "segment.name";
+ public static final String SEGMENT_NAME_PREFIX = "segment.name.prefix";
+ public static final String SEGMENT_NAME_POSTFIX = "segment.name.postfix";
Review comment:
I tried to keep the property names same as the ones in the existing yml
batch job spec. It uses postfix there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
