mcvsubbu commented on a change in pull request #6737:
URL: https://github.com/apache/incubator-pinot/pull/6737#discussion_r606309917
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java
##########
@@ -243,39 +246,38 @@ private SuccessResponse addSchema(Schema schema, boolean
override) {
return new SuccessResponse(schemaName + " successfully added");
} catch (Exception e) {
_controllerMetrics.addMeteredGlobalValue(ControllerMeter.CONTROLLER_SCHEMA_UPLOAD_ERROR,
1L);
- throw new ControllerApplicationException(LOGGER,
- String.format("Failed to add new schema %s.", schemaName),
Response.Status.INTERNAL_SERVER_ERROR,
- e);
+ throw new ControllerApplicationException(LOGGER, String.format("Failed
to add new schema %s.", schemaName),
Review comment:
Won't this end up throwing 5xx if schema update failed due to backward
incompatibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
