fx19880617 commented on a change in pull request #6744:
URL: https://github.com/apache/incubator-pinot/pull/6744#discussion_r607386154
##########
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/segment_generation_and_push/SegmentGenerationAndPushTaskExecutor.java
##########
@@ -221,29 +222,39 @@ private URI moveSegmentToOutputPinotFS(Map<String,
String> taskConfigs, File loc
return outputSegmentTarURI;
}
- private PinotFS getInputPinotFS(Map<String, String> taskConfigs, URI
fileURI) {
+ private PinotFS getInputPinotFS(Map<String, String> taskConfigs, URI fileURI)
+ throws Exception {
String fileURIScheme = fileURI.getScheme();
if (fileURIScheme == null) {
- fileURIScheme = PinotFSFactory.LOCAL_PINOT_FS_SCHEME;
+ return LOCAL_PINOT_FS;
}
- if (!PinotFSFactory.isSchemeSupported(fileURIScheme)) {
- String fsClass = taskConfigs.get(BatchConfigProperties.INPUT_FS_CLASS);
+ // Try to create PinotFS using given Input FileSystem config always
+ String fsClass = taskConfigs.get(BatchConfigProperties.INPUT_FS_CLASS);
Review comment:
You can always assume that there are two AWS credentials:
1. Pinot Credential: this is used by pinot only to leverage s3 as the deep
store.
2. Data ingestion Credential: this is per user basis, it requires another
AWS credential for data reading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
