Jackie-Jiang commented on a change in pull request #6748:
URL: https://github.com/apache/incubator-pinot/pull/6748#discussion_r608246953
##########
File path: pom.xml
##########
@@ -1660,63 +1668,51 @@
</executions>
<configuration>
<excludes>
- <!-- Sphynx auto generated makefile -->
- <exclude>docs/Makefile</exclude>
-
- <!-- Exclude build files for docs -->
- <exclude>docs/_build/**</exclude>
-
<!-- Exclude license copies -->
<exclude>licenses/**</exclude>
<exclude>licenses-binary/**</exclude>
<!-- Exclude build targets -->
<exclude>**/target/**</exclude>
+ <!-- Text and log files -->
+ <exclude>**/*.txt</exclude>
+ <exclude>**/*.log</exclude>
+ <exclude>**/*.list</exclude>
+ <exclude>**/*.out</exclude>
+ <exclude>**/*.generated</exclude>
+ <exclude>**/java.sql.Driver</exclude>
+
<exclude>**/org.apache.spark.sql.sources.DataSourceRegister</exclude>
+
+ <!-- Binary files -->
+ <exclude>**/*.avro</exclude>
+ <exclude>**/*.avsc</exclude>
+ <exclude>**/*.csv</exclude>
+ <exclude>**/*.desc</exclude>
+ <exclude>**/*.parquet</exclude>
+ <exclude>**/*.gz</exclude>
+ <exclude>**/*.orc</exclude>
+ <exclude>**/*.dict</exclude>
+ <exclude>**/*.raw</exclude>
+ <exclude>**/*.mapping</exclude>
+ <exclude>**/*.ser</exclude>
+ <exclude>**/*.v1</exclude>
+ <exclude>**/*.v2</exclude>
+ <exclude>**/appAssemblerScriptTemplate</exclude>
<!-- js, css files that are exact copies of the third-party works.
In this case, the original header has to
be kept. Please refer to 'Treatment of Third-party works' in
https://www.apache.org/legal/src-headers.html
-->
- <exclude>**/codemirror/**</exclude>
- <exclude>**/codemirror*</exclude>
- <exclude>**/foundation*</exclude>
- <exclude>**/angular*</exclude>
- <exclude>**/underscore*</exclude>
- <exclude>**/jquery*</exclude>
- <exclude>**/normalize*</exclude>
- <exclude>**/handlebars*</exclude>
- <exclude>**/beautify*</exclude>
- <exclude>**/src/main/resources/.*</exclude>
- <exclude>**/src/main/resources/dist/**</exclude>
- <exclude>**/src/main/resources/node_modules/**</exclude>
-
- <!-- Binary files -->
- <exclude>**/*.json</exclude>
- <exclude>**/*.pql</exclude>
- <exclude>**/*.log</exclude>
- <exclude>**/*.csv</exclude>
- <exclude>**/*.avro</exclude>
- <exclude>**/*.conf</exclude>
- <exclude>**/*.config</exclude>
- <exclude>**/*.yml</exclude>
- <exclude>**/*.yaml</exclude>
- <exclude>**/*.properties</exclude>
+ <exclude>**/node_modules/**</exclude>
+ <exclude>**/dist/**</exclude>
+ <exclude>**/*.*rc</exclude>
<!-- IDE files -->
<exclude>**/*.iml</exclude>
<!-- Top level -->
<exclude>.codecov*</exclude>
Review comment:
Let's add header to `.codecov.yml` and remove this exclusion
##########
File path: rstheaderdefinition.xml
##########
@@ -30,4 +30,14 @@
<isMultiline>true</isMultiline>
<padLines>false</padLines>
</rst_style>
+ <javadoc_style>
Review comment:
Rename this file to `headerdefinitions.xml`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
