siddharthteotia commented on a change in pull request #6776:
URL: https://github.com/apache/incubator-pinot/pull/6776#discussion_r612125139
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/pruner/ColumnValueSegmentPruner.java
##########
@@ -59,8 +62,11 @@
@SuppressWarnings({"rawtypes", "unchecked"})
public class ColumnValueSegmentPruner implements SegmentPruner {
+ private int _inPredicateThreshold;
+
@Override
public void init(PinotConfiguration config) {
+ _inPredicateThreshold =
config.getProperty(Server.CONFIG_THRESHOLD_FOR_IN_PREDICATE,
Server.DEFAULT_VALUE_FOR_IN_PREDICATE_THRESHOLD);
Review comment:
I think it might make the name look cleaner. However, keeping the dot
notation based name makes it consistent with all the config keys we have today.
Also the name makes it self explanatory that it is for pruner on server query
execution
What do you guys think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
