Jackie-Jiang commented on a change in pull request #6765:
URL: https://github.com/apache/incubator-pinot/pull/6765#discussion_r614597860
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -294,7 +294,7 @@ public BrokerResponse handleRequest(JsonNode request,
@Nullable RequesterIdentit
if ((offlineTableName == null) && (realtimeTableName == null)) {
// No table matches the request
LOGGER.info("No table matches for request {}: {}", requestId, query);
-
requestStatistics.setErrorCode(QueryException.BROKER_RESOURCE_MISSING_ERROR_CODE);
+
requestStatistics.setErrorCode(QueryException.TABLE_DOES_NOT_EXIST_ERROR_CODE);
_brokerMetrics.addMeteredGlobalValue(BrokerMeter.RESOURCE_MISSING_EXCEPTIONS,
1);
Review comment:
Yes. Currently there are 2 scenarios that can cause broker resource
missing:
1. Table does not exist - should raise the table does not exist error
2. Table exists but not available in broker routing - should raise the
broker resource missing error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
