mayankshriv commented on a change in pull request #6822:
URL: https://github.com/apache/incubator-pinot/pull/6822#discussion_r617098639



##########
File path: 
pinot-core/src/main/java/org/apache/pinot/core/util/ListenerConfigUtil.java
##########
@@ -143,6 +143,27 @@ private ListenerConfigUtil() {
     return listeners;
   }
 
+  public static List<ListenerConfig> 
buildMinionAdminConfigs(PinotConfiguration minionConf) {
+    List<ListenerConfig> listeners = new ArrayList<>();
+
+    String adminApiPortString = 
minionConf.getProperty(CommonConstants.Minion.CONFIG_OF_ADMIN_API_PORT);
+    if (adminApiPortString != null) {

Review comment:
       This is what all other components are doing as well, I tried to match 
that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to