Jackie-Jiang commented on a change in pull request #6820:
URL: https://github.com/apache/incubator-pinot/pull/6820#discussion_r617195459
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeFunctions.java
##########
@@ -261,6 +262,15 @@ public static long now() {
return System.currentTimeMillis();
}
+ /**
+ * Return time as epoch millis before the given period (represented by as an
ISO8601 formatted String).
Review comment:
Put some example period string in the javadoc?
From the javadoc of `Duration.parse()`:
```
The formats accepted are based on the ISO-8601 duration format {@code
PnDTnHnMn.nS} with days considered to be exactly 24 hours.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
