elonazoulay commented on a change in pull request #6831:
URL: https://github.com/apache/incubator-pinot/pull/6831#discussion_r617915050
##########
File path:
pinot-plugins/pinot-file-system/pinot-gcs/src/main/java/org/apache/pinot/plugin/filesystem/GcsPinotFS.java
##########
@@ -191,6 +191,9 @@ public boolean mkdir(URI uri) throws IOException {
if (path.equals(DELIMITER)) {
return true;
}
+ if (isDirectory(uri)) {
Review comment:
Wanted to return fast if path is just the root. This way it minimizes
gcs calls. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
