Jackie-Jiang commented on a change in pull request #6855:
URL: https://github.com/apache/incubator-pinot/pull/6855#discussion_r621741189
##########
File path:
pinot-common/src/main/java/org/apache/pinot/parsers/QueryCompiler.java
##########
@@ -24,6 +24,10 @@
/**
* Interface for Pinot Query compilers.
*/
-public interface AbstractCompiler {
- BrokerRequest compileToBrokerRequest(String expression);
+public interface QueryCompiler {
Review comment:
Yeah, this is internal only. Naming an interface `Abstract*` seems very
weird to me, so changed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
