mcvsubbu commented on a change in pull request #6901:
URL: https://github.com/apache/incubator-pinot/pull/6901#discussion_r630554525
##########
File path: compatibility-verifier/compCheck.sh
##########
@@ -70,21 +70,31 @@ function waitForClusterReady() {
sleep 2
echo "Cluster ready."
}
+
+#set config file is present or not
+function setConfigFile() {
Review comment:
```suggestion
function setConfigFileArg() {
```
##########
File path: compatibility-verifier/compCheck.sh
##########
@@ -156,6 +170,13 @@ function absPath() {
echo "$testSuiteDirPath"
}
+#check if config file is present or not
+function checkConfigFile() {
+ if [[ -e $1 ]]; then
Review comment:
```suggestion
if [[ -f $1 ]]; then
```
##########
File path: compatibility-verifier/compCheck.sh
##########
@@ -70,21 +70,31 @@ function waitForClusterReady() {
sleep 2
echo "Cluster ready."
}
+
+#set config file is present or not
+function setConfigFile() {
+ if [[ -n $1 ]]; then
+ echo "-configFileName ${1}"
+ fi
+}
+
# Given a component and directory, start that version of the specific component
function startService() {
serviceName=$1
dirName=$2
+ local configFile=$(setConfigFile "$3")
Review comment:
```suggestion
local configFileArg=$(setConfigFile "$3")
```
##########
File path: compatibility-verifier/compCheck.sh
##########
@@ -70,21 +70,31 @@ function waitForClusterReady() {
sleep 2
echo "Cluster ready."
}
+
+#set config file is present or not
+function setConfigFile() {
+ if [[ -n $1 ]]; then
Review comment:
why don't we just check if file exists (using -f) here and populate the
configFileArg?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
