siddharthteotia commented on a change in pull request #6927:
URL: https://github.com/apache/incubator-pinot/pull/6927#discussion_r640771794
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java
##########
@@ -271,7 +242,211 @@ private Expression rewrite(Expression equals, Expression
lhs, Expression rhs, Sc
break;
}
}
+ }
}
return equals;
}
+
+ /**
+ * Rewrite expressions of form "column > literal", "column >= literal",
"column < literal", and "column <= literal"
+ * to ensure that RHS literal is the same datatype as LHS column.
+ */
Review comment:
Let's add a TODO for BETWEEN ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
