Jackie-Jiang commented on a change in pull request #7259:
URL: https://github.com/apache/pinot/pull/7259#discussion_r683877609
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java
##########
@@ -658,9 +657,16 @@ public boolean equals(Object o) {
}
/**
- * Check whether the current schema is backward compatible with oldSchema.
+ * Check whether the current schema is backward compatible with the given
old schema. The current schema can be
+ * modified in-place to match the old schema.
Review comment:
Good point, updated the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
