jtao15 commented on a change in pull request #7260:
URL: https://github.com/apache/pinot/pull/7260#discussion_r685598954
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/transport/InstanceRequestHandler.java
##########
@@ -184,9 +185,9 @@ private void sendResponse(ChannelHandlerContext ctx, String
tableNameWithType, l
_serverMetrics.addTimedTableValue(tableNameWithType,
ServerTimer.NETTY_CONNECTION_SEND_RESPONSE_LATENCY,
sendResponseLatencyMs, TimeUnit.MILLISECONDS);
- int totalQueryTimeMs = (int) (sendResponseEndTimeMs -
queryArrivalTimeMs);
- if (totalQueryTimeMs > SLOW_QUERY_LATENCY_THRESHOLD_MS) {
- LOGGER.info(
+ long totalQueryTimeMs = sendResponseEndTimeMs - queryArrivalTimeMs;
+ if (totalQueryTimeMs > _slowQueryLatencyThresholdMs) {
+ LOGGER.warn(
Review comment:
This can still be useful? Since it shows the latency to send the
response to broker which is not available in the `INFO` log? Also this can help
to identify slow servers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
