klsince commented on a change in pull request #7301:
URL: https://github.com/apache/pinot/pull/7301#discussion_r690617694
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/FilePerIndexDirectory.java
##########
@@ -97,17 +98,14 @@ public void close()
@Override
public void removeIndex(String columnName, ColumnIndexType indexType) {
- File indexFile = getFileFor(columnName, indexType);
- if (indexFile.delete()) {
Review comment:
1. file.delete() can't remove folder, while TextIndex is put in a
folder.
2. TextIndex has two parts: the index data in folder; and another mapping
file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
