walterddr commented on a change in pull request #7473:
URL: https://github.com/apache/pinot/pull/7473#discussion_r714980472
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/IngestionUtils.java
##########
@@ -110,8 +112,6 @@ public static SegmentGeneratorConfig
generateSegmentGeneratorConfig(TableConfig
// apply config override provided by user.
Map<String, String> batchConfigMap = new
HashMap<>(batchIngestionConfig.getBatchConfigMaps().get(0));
Review comment:
good catch this is not needed.
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/IngestionUtils.java
##########
@@ -88,20 +87,23 @@ private IngestionUtils() {
*/
public static SegmentGeneratorConfig
generateSegmentGeneratorConfig(TableConfig tableConfig, Schema schema)
throws IOException, ClassNotFoundException {
- return generateSegmentGeneratorConfig(tableConfig, schema,
Collections.emptyMap());
+ Preconditions.checkNotNull(tableConfig.getIngestionConfig(),
+ "Must provide ingestionConfig in tableConfig for table: %s, for
generating SegmentGeneratorConfig",
+ tableConfig.getTableName());
+
Preconditions.checkNotNull(tableConfig.getIngestionConfig().getBatchIngestionConfig(),
Review comment:
yeah i was trying to differentiate between tableconfig that contains the
batch ingestion config. vs the batchingestionconfig is individually passed in
as a separate argument. but you are right no need to separately check
programmatically. this is more for logging purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]