npawar commented on a change in pull request #7493:
URL: https://github.com/apache/pinot/pull/7493#discussion_r718780263
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseCombineOperator.java
##########
@@ -153,7 +154,18 @@ public void runJob() {
*/
protected void processSegments(int threadIndex) {
for (int operatorIndex = threadIndex; operatorIndex < _numOperators;
operatorIndex += _numThreads) {
- IntermediateResultsBlock resultsBlock = (IntermediateResultsBlock)
_operators.get(operatorIndex).nextBlock();
+ Operator operator = _operators.get(operatorIndex);
+ IntermediateResultsBlock resultsBlock;
+ try {
+ if (operator instanceof AcquireReleaseColumnsSegmentOperator) {
+ ((AcquireReleaseColumnsSegmentOperator) operator).acquire();
+ }
Review comment:
actually i intentionally put it inside the try, so that we release no
matter what happens in acquire or execution
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseCombineOperator.java
##########
@@ -153,7 +154,18 @@ public void runJob() {
*/
protected void processSegments(int threadIndex) {
for (int operatorIndex = threadIndex; operatorIndex < _numOperators;
operatorIndex += _numThreads) {
- IntermediateResultsBlock resultsBlock = (IntermediateResultsBlock)
_operators.get(operatorIndex).nextBlock();
+ Operator operator = _operators.get(operatorIndex);
+ IntermediateResultsBlock resultsBlock;
+ try {
+ if (operator instanceof AcquireReleaseColumnsSegmentOperator) {
+ ((AcquireReleaseColumnsSegmentOperator) operator).acquire();
+ }
Review comment:
following up to our offline discussion about it not following
lock/unlock semantics, will stick to this for now and revisit if need be, since
functionality wise it's the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
