snleee commented on a change in pull request #7509:
URL: https://github.com/apache/pinot/pull/7509#discussion_r720600592



##########
File path: 
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -2784,7 +2784,14 @@ public void endReplaceSegments(String tableNameWithType, 
String segmentLineageEn
                 + "segmentsFromTable = '%s')", tableNameWithType, 
lineageEntry.getSegmentsTo(), segmentsForTable));
 
         // Check that all the segments from 'segmentsTo' become ONLINE in the 
external view
-        waitForSegmentsBecomeOnline(tableNameWithType, new 
HashSet<>(lineageEntry.getSegmentsTo()));
+        try {
+          waitForSegmentsBecomeOnline(tableNameWithType, new 
HashSet<>(lineageEntry.getSegmentsTo()));
+        } catch (TimeoutException e) {
+          LOGGER.error(String

Review comment:
       Let's use `WARN`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to