jtao15 commented on a change in pull request #7516:
URL: https://github.com/apache/pinot/pull/7516#discussion_r724584181



##########
File path: 
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/test/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskExecutorTest.java
##########
@@ -104,7 +104,7 @@ public void setUp()
   @Test
   public void testConvert()
       throws Exception {
-    MergeRollupTaskExecutor mergeRollupTaskExecutor = new 
MergeRollupTaskExecutor();
+    MergeRollupTaskExecutor mergeRollupTaskExecutor = new 
MergeRollupTaskExecutor(null);

Review comment:
       Updated the constructor to use `MinionConf` as input instead. Hmm, this 
requires to add the default constructor explicitly while the config should be a 
required field. Maybe we can use `new MinionConf()` instead cause this field 
should never be `null`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to