richardstartin commented on a change in pull request #7542:
URL: https://github.com/apache/pinot/pull/7542#discussion_r725191626
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/InTransformFunction.java
##########
@@ -81,77 +95,112 @@ public TransformResultMetadata getResultMetadata() {
switch (storedType) {
case INT:
int[] intValues =
_transformFunction.transformToIntValuesSV(projectionBlock);
- int[][] inIntValues = new int[_valueTransformFunctions.length][];
- for (int i = 0; i < _valueTransformFunctions.length; i++) {
- inIntValues[i] =
_valueTransformFunctions[i].transformToIntValuesSV(projectionBlock);
- }
- for (int i = 0; i < length; i++) {
- for (int j = 0; j < inIntValues.length; j++) {
- _results[i] = inIntValues[j][i] == intValues[i] ? 1 : _results[i];
+ if (!_stringValueSet.isEmpty()) {
+ Set<Integer> inIntValues = new HashSet<>();
+ for (String inValue : _stringValueSet) {
+ inIntValues.add(Integer.parseInt(inValue));
+ }
+ for (int i = 0; i < length; i++) {
+ _results[i] = inIntValues.contains(intValues[i]) ? 1 : 0;
+ }
+ } else {
+ int[][] inIntValues = new int[_valueTransformFunctions.length][];
+ for (int i = 0; i < _valueTransformFunctions.length; i++) {
+ inIntValues[i] =
_valueTransformFunctions[i].transformToIntValuesSV(projectionBlock);
+ }
+ for (int i = 0; i < length; i++) {
+ for (int j = 0; j < inIntValues.length; j++) {
+ _results[i] = inIntValues[j][i] == intValues[i] ? 1 :
_results[i];
+ }
}
}
break;
case LONG:
long[] longValues =
_transformFunction.transformToLongValuesSV(projectionBlock);
- long[][] inLongValues = new long[_valueTransformFunctions.length][];
- for (int i = 0; i < _valueTransformFunctions.length; i++) {
- inLongValues[i] =
_valueTransformFunctions[i].transformToLongValuesSV(projectionBlock);
- }
- for (int i = 0; i < length; i++) {
- for (int j = 0; j < inLongValues.length; j++) {
- _results[i] = inLongValues[j][i] == longValues[i] ? 1 :
_results[i];
+ if (!_stringValueSet.isEmpty()) {
+ Set<Long> inLongValues = new HashSet<>();
+ for (String inValue : _stringValueSet) {
+ inLongValues.add(Long.parseLong(inValue));
+ }
+ for (int i = 0; i < length; i++) {
+ _results[i] = inLongValues.contains(longValues[i]) ? 1 : 0;
+ }
+ } else {
+ long[][] inLongValues = new long[_valueTransformFunctions.length][];
+ for (int i = 0; i < _valueTransformFunctions.length; i++) {
+ inLongValues[i] =
_valueTransformFunctions[i].transformToLongValuesSV(projectionBlock);
+ }
+ for (int i = 0; i < length; i++) {
+ for (int j = 0; j < inLongValues.length; j++) {
+ _results[i] = inLongValues[j][i] == longValues[i] ? 1 :
_results[i];
+ }
}
}
break;
case FLOAT:
float[] floatValues =
_transformFunction.transformToFloatValuesSV(projectionBlock);
- float[][] inFloatValues = new float[_valueTransformFunctions.length][];
- for (int i = 0; i < _valueTransformFunctions.length; i++) {
- inFloatValues[i] =
_valueTransformFunctions[i].transformToFloatValuesSV(projectionBlock);
- }
- for (int i = 0; i < length; i++) {
- for (int j = 0; j < inFloatValues.length; j++) {
- _results[i] = Float.compare(inFloatValues[j][i], floatValues[i])
== 0 ? 1 : _results[i];
+ if (!_stringValueSet.isEmpty()) {
+ Set<Float> inFloatValues = new HashSet<>();
+ for (String inValue : _stringValueSet) {
+ inFloatValues.add(Float.parseFloat(inValue));
+ }
+ for (int i = 0; i < length; i++) {
+ _results[i] = inFloatValues.contains(floatValues[i]) ? 1 : 0;
+ }
+ } else {
+ float[][] inFloatValues = new
float[_valueTransformFunctions.length][];
+ for (int i = 0; i < _valueTransformFunctions.length; i++) {
+ inFloatValues[i] =
_valueTransformFunctions[i].transformToFloatValuesSV(projectionBlock);
+ }
+ for (int i = 0; i < length; i++) {
+ for (int j = 0; j < inFloatValues.length; j++) {
+ _results[i] = Float.compare(inFloatValues[j][i], floatValues[i])
== 0 ? 1 : _results[i];
+ }
}
}
break;
case DOUBLE:
double[] doubleValues =
_transformFunction.transformToDoubleValuesSV(projectionBlock);
- double[][] inDoubleValues = new
double[_valueTransformFunctions.length][];
- for (int i = 0; i < _valueTransformFunctions.length; i++) {
- inDoubleValues[i] =
_valueTransformFunctions[i].transformToDoubleValuesSV(projectionBlock);
- }
- for (int i = 0; i < length; i++) {
- for (int j = 0; j < inDoubleValues.length; j++) {
- _results[i] = Double.compare(inDoubleValues[j][i],
doubleValues[i]) == 0 ? 1 : _results[i];
+ if (!_stringValueSet.isEmpty()) {
+ Set<Double> inDoubleValues = new HashSet<>();
+ for (String inValue : _stringValueSet) {
+ inDoubleValues.add(Double.parseDouble(inValue));
+ }
+ for (int i = 0; i < length; i++) {
+ _results[i] = inDoubleValues.contains(doubleValues[i]) ? 1 : 0;
+ }
+ } else {
+ double[][] inDoubleValues = new
double[_valueTransformFunctions.length][];
+ for (int i = 0; i < _valueTransformFunctions.length; i++) {
+ inDoubleValues[i] =
_valueTransformFunctions[i].transformToDoubleValuesSV(projectionBlock);
+ }
+ for (int i = 0; i < length; i++) {
+ for (int j = 0; j < inDoubleValues.length; j++) {
+ _results[i] = Double.compare(inDoubleValues[j][i],
doubleValues[i]) == 0 ? 1 : _results[i];
+ }
}
}
break;
case STRING:
String[] stringValues =
_transformFunction.transformToStringValuesSV(projectionBlock);
- String[][] inStringValues = new
String[_valueTransformFunctions.length][];
- for (int i = 0; i < _valueTransformFunctions.length; i++) {
- inStringValues[i] =
_valueTransformFunctions[i].transformToStringValuesSV(projectionBlock);
- }
- for (int i = 0; i < length; i++) {
- for (int j = 0; j < inStringValues.length; j++) {
- _results[i] = inStringValues[j][i].equals(stringValues[i]) ? 1 :
_results[i];
+ if (!_stringValueSet.isEmpty()) {
+ for (int i = 0; i < length; i++) {
+ _results[i] = _stringValueSet.contains(stringValues[i]) ? 1 : 0;
}
- }
- break;
- case BYTES:
- byte[][] bytesValues =
_transformFunction.transformToBytesValuesSV(projectionBlock);
- byte[][][] inBytesValues = new
byte[_valueTransformFunctions.length][][];
- for (int i = 0; i < _valueTransformFunctions.length; i++) {
- inBytesValues[i] =
_valueTransformFunctions[i].transformToBytesValuesSV(projectionBlock);
- }
- for (int i = 0; i < length; i++) {
- for (int j = 0; j < inBytesValues.length; j++) {
- _results[i] =
- new ByteArray(inBytesValues[j][i]).compareTo(new
ByteArray(bytesValues[i])) == 0 ? 1 : _results[i];
+ } else {
+ String[][] inStringValues = new
String[_valueTransformFunctions.length][];
+ for (int i = 0; i < _valueTransformFunctions.length; i++) {
+ inStringValues[i] =
_valueTransformFunctions[i].transformToStringValuesSV(projectionBlock);
+ }
+ for (int i = 0; i < length; i++) {
+ for (int j = 0; j < inStringValues.length; j++) {
+ _results[i] = inStringValues[j][i].equals(stringValues[i]) ? 1 :
_results[i];
+ }
}
}
break;
+ case BYTES:
+ throw new UnsupportedOperationException();
Review comment:
Sorry I'm new to pinot, it doesn't seem that there is a base64 function
to specify binary literals. So I wouldn't suggest adding to implement this for
bytes, I can just imagine wanting to do this for e.g. security use cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
