jackjlli commented on a change in pull request #7644:
URL: https://github.com/apache/pinot/pull/7644#discussion_r737699130
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -1481,6 +1492,9 @@ private static String getActualColumnName(String
rawTableName, String columnName
return actualAlias;
}
}
+ if (!throwExceptionForInvalidColumn) {
+ return columnName;
Review comment:
Correct, but that's just for the scenarios when the
`BadQueryRequestException` gets thrown. In this case, the exception never gets
thrown. Maybe we should move the metric down to the line before Line 1495?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
