snleee commented on a change in pull request #7646:
URL: https://github.com/apache/pinot/pull/7646#discussion_r738188420
##########
File path:
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/name/NormalizedDateSegmentNameGenerator.java
##########
@@ -38,25 +38,27 @@
// we will need to create a new top level module for such constants and
define them there.
private static final String PUSH_FREQUENCY_HOURLY = "hourly";
- private String _segmentNamePrefix;
- private boolean _excludeSequenceId;
- private boolean _appendPushType;
+ private final String _segmentNamePrefix;
+ private final boolean _excludeSequenceId;
+ private final boolean _appendPushType;
+ private final String _segmentNamePostfix;
// For APPEND tables
- private SimpleDateFormat _outputSDF;
+ private final SimpleDateFormat _outputSDF;
// For EPOCH time format
- private TimeUnit _inputTimeUnit;
+ private final TimeUnit _inputTimeUnit;
// For SIMPLE_DATE_FORMAT time format
- private SimpleDateFormat _inputSDF;
+ private final SimpleDateFormat _inputSDF;
public NormalizedDateSegmentNameGenerator(String tableName, @Nullable String
segmentNamePrefix,
boolean excludeSequenceId, @Nullable String pushType, @Nullable String
pushFrequency,
- @Nullable DateTimeFormatSpec dateTimeFormatSpec) {
+ @Nullable DateTimeFormatSpec dateTimeFormatSpec, @Nullable String
segmentNamePostfix) {
Review comment:
Should we create a new constructor to make the class backward
compatible? This change will break the external code that depends on this class
(i.e. our internal offline push flow).
I'm personally fine with keeping this way as long as you make sure to update
the external code accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]