xiangfu0 commented on a change in pull request #7692:
URL: https://github.com/apache/pinot/pull/7692#discussion_r743176327
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableImplV3.java
##########
@@ -175,8 +175,11 @@ public DataTableImplV3(ByteBuffer byteBuffer)
}
@Override
- public void addException(ProcessingException processingException) {
- _errCodeToExceptionMap.put(processingException.getErrorCode(),
processingException.getMessage());
+ public void addException(Exception exception) {
+ if (exception instanceof ProcessingException) {
Review comment:
any chance we add other exceptions here?
Shall we add a log here if the exception is not ProcessingException?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
