walterddr commented on a change in pull request #7695:
URL: https://github.com/apache/pinot/pull/7695#discussion_r743244149
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/plan/PlanNode.java
##########
@@ -18,16 +18,16 @@
*/
package org.apache.pinot.core.plan;
-import org.apache.pinot.core.common.Block;
import org.apache.pinot.core.common.Operator;
+import org.apache.pinot.query.spi.data.Block;
import org.apache.pinot.spi.annotations.InterfaceAudience;
/**
* The <code>PlanNode</code> is a single execution plan node inside the {@link
Plan} tree.
*/
@InterfaceAudience.Private
-public interface PlanNode {
+public interface PlanNode extends org.apache.pinot.query.spi.plan.PlanNode {
Review comment:
TODO item1:
This cannot be cleanly factor out because of Operator issue. Ideally this
should be
```
public interface PlanNode<O extends Operator> {
O<? extends Block> run();
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]