amrishlal commented on a change in pull request #7678:
URL: https://github.com/apache/pinot/pull/7678#discussion_r743879101
##########
File path:
pinot-core/src/test/java/org/apache/pinot/queries/DistinctQueriesTest.java
##########
@@ -580,18 +578,16 @@ private void testDistinctInnerSegmentHelper(String[]
queries, boolean isPql) {
*/
@Test
public void testDistinctInnerSegment() {
- testDistinctInnerSegmentHelper(
- new String[]{
- "SELECT DISTINCT(intColumn, longColumn, floatColumn, doubleColumn,
stringColumn, bytesColumn) FROM "
- + "testTable LIMIT 10000",
- "SELECT DISTINCT(stringColumn, bytesColumn, floatColumn) FROM
testTable WHERE intColumn >= 60 LIMIT 10000",
- "SELECT DISTINCT(intColumn, rawBytesColumn) FROM testTable ORDER
BY rawBytesColumn LIMIT 5",
- "SELECT DISTINCT(ADD(intColumn, floatColumn), stringColumn) FROM
testTable WHERE longColumn < 60 ORDER BY"
- + " stringColumn DESC, ADD(intColumn, floatColumn) ASC LIMIT
10",
- "SELECT DISTINCT(floatColumn, longColumn) FROM testTable WHERE
stringColumn = 'a' ORDER BY longColumn "
- + "LIMIT 10"
- },
- true);
+ testDistinctInnerSegmentHelper(new String[]{
+ "SELECT DISTINCT(intColumn, longColumn, floatColumn, doubleColumn,
stringColumn, bytesColumn) FROM "
+ + "testTable LIMIT 10000",
+ "SELECT DISTINCT(stringColumn, bytesColumn, floatColumn) FROM
testTable WHERE " + "intColumn >= 60 LIMIT 10000",
+ "SELECT DISTINCT(intColumn, rawBytesColumn) FROM testTable ORDER BY "
+ "rawBytesColumn LIMIT 5",
Review comment:
minor: Concatenation of two strings in these two lines can be replaced
by a single string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
