amrishlal commented on pull request #7678: URL: https://github.com/apache/pinot/pull/7678#issuecomment-962660303
> > However, this fix still appears a bit "hacky" since AsTransformFunction is used only during compile time and then discarded. One way to fix this might be to modify `org.apache.pinot.common.request.Function` to contain a list of output aliases (?) Since DISTINCT is a Function that outputs an entire row (and there are probably other functions like this), it makes sense for `Function` to have a list of aliases for the row output as well (?) and this will avoid the use of `AsTransformFunction` and all we would need to do is to fetch the list of aliases from the Function and set it (?) > > In this case, then we should try to delete the AsTransformFunction and try to compute the alias at the beginning then replace the AS expression to just its left expression. > > Typical query engine can generate the query plan with the output column names. ok thanks, LGTM now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
