Jackie-Jiang commented on a change in pull request #7692:
URL: https://github.com/apache/pinot/pull/7692#discussion_r745091691
##########
File path:
pinot-connectors/pinot-spark-connector/src/test/scala/org/apache/pinot/connector/spark/connector/PinotUtilsTest.scala
##########
@@ -19,12 +19,11 @@
package org.apache.pinot.connector.spark.connector
import org.apache.pinot.connector.spark.connector.PinotUtils._
-import org.apache.pinot.common.utils.DataSchema
-import org.apache.pinot.common.utils.DataSchema.ColumnDataType
+import org.apache.pinot.spi.data.DataSchema.ColumnDataType
import org.apache.pinot.connector.spark.BaseTest
import org.apache.pinot.connector.spark.exceptions.PinotException
import org.apache.pinot.core.common.datatable.DataTableBuilder
-import org.apache.pinot.spi.data.Schema
+import org.apache.pinot.spi.data.{DataSchema, Schema}
Review comment:
Split into 2 imports
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/DataSchema.java
##########
@@ -40,7 +40,10 @@
/**
- * The <code>DataSchema</code> class describes the schema of {@link DataTable}.
+ * The <code>DataSchema</code> class describes the columnName and columnType
of a row.
+ *
+ * <p>Comparing with {@link Schema} it doesn't contain any {@link FieldSpec}
information except for the DataType.
Review comment:
Schema is used to describe the table; DataSchema is used to describe the
query results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
