mneedham commented on a change in pull request #7776:
URL: https://github.com/apache/pinot/pull/7776#discussion_r750314519
##########
File path:
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/name/SimpleSegmentNameGenerator.java
##########
@@ -50,6 +50,12 @@ public SimpleSegmentNameGenerator(String segmentNamePrefix,
@Nullable String seg
@Override
public String generateSegmentName(int sequenceId, @Nullable Object
minTimeValue, @Nullable Object maxTimeValue) {
+ if (minTimeValue != null) {
+ minTimeValue = minTimeValue.toString().replaceAll("[: \\/]", "_");
Review comment:
got it, have updated it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]