walterddr opened a new issue #7778: URL: https://github.com/apache/pinot/issues/7778
See: https://github.com/apache/pinot/blob/611f3b11b1336bc9f426ead5ba908a9632a50fd9/pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-common/src/main/java/org/apache/pinot/plugin/ingestion/batch/common/SegmentGenerationTaskRunner.java#L105. By the time SegmentGeneratorConfig is created. 1. it is not using `IngestionUtils.generateSegmentGeneratorConfig` to generate segmentGeneratorConfig. 2. even if so. the SegmentNameGenerator is created without the knowledge of the tableConfig. Thus if we set the segmentnamegenerator config in tableconfig.ingestionConfig.BatchIngestconfig.BatchConfigMap. it is not honored. I was wondering if there's a general rule of thumb on what to expect when users are setting the configuration. For example in this case when using the ingestion plugin. setting in tableConfig directly is useless and it doing what the user wanted. which makes it hard to debug/trace because nothing fails. From my point of view we should have a rule of thumb. If one setting/config-key is provided in multiple places, then: * plugin configuration > table config > pinot default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
