richardstartin commented on a change in pull request #7777:
URL: https://github.com/apache/pinot/pull/7777#discussion_r751781127
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java
##########
@@ -253,12 +252,29 @@ public int getNumKeys() {
}
private class ArrayBasedHolder implements RawKeyHolder {
- // TODO: using bitmap might better
Review comment:
No it’s not a good idea because it creates data dependencies between any
contiguous set of 64 groups as they all need to update the same word. I tried
it and it was about 30% worse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
