richardstartin commented on a change in pull request #7861:
URL: https://github.com/apache/pinot/pull/7861#discussion_r761915847
##########
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##########
@@ -96,8 +96,36 @@ private CalciteSqlParser() {
private static final Pattern OPTIONS_REGEX_PATTEN =
Pattern.compile("option\\s*\\(([^\\)]+)\\)", Pattern.CASE_INSENSITIVE);
+ /**
+ * Checks for the presence of semicolon in the sql query and modifies the
query accordingly
+ *
+ * @param sql sql query
+ * @return sql query without semicolons
+ *
+ */
+ private static String checkForSemicolonInTheQuery(String sql) {
+ // Check if the query has semicolon
+ int semiColonIndex = sql.indexOf(';');
+ if (semiColonIndex > -1) {
+ // Split the input query based on semicolon
+ String[] sqlSplit = sql.split(";");
+
+ // If only semicolons are present in the input query
+ if (sqlSplit.length == 0) {
+ new SqlCompilationException("Caught exception while parsing query: " +
sql);
+ } else {
+ // After spliting take the string present at 0th index and then parse
the SQL
+ sql = sqlSplit[0];
+ }
Review comment:
Also, rather than just take the first statement, it should maybe throw
if there is sql after a semicolon, in case the user thinks that multiple
statements can be executed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
