yeongjukang commented on a change in pull request #7884:
URL: https://github.com/apache/pinot/pull/7884#discussion_r766315843
##########
File path: docker/images/pinot-presto/README.md
##########
@@ -34,9 +34,10 @@ This docker build project is specialized for Pinot.
You can also build directly with `docker build` command by setting arguments:
```bash
docker build \
- --build-arg PRESTO_BRANCH=master \
+ --build-arg PRESTO_GIT_URL=$PRESTO_GIT_URL \
+ --build-arg PRESTO_BRANCH=$PRESTO_BRANCH \
--tag apachepinot/pinot-presto:latest \
- --target build .
+ .
Review comment:
[New
readme](https://github.com/yeongjukang/pinot/blob/patch-1/docker/images/pinot-presto/README.md)
has proper dot. I think diff has problem on L39.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
