Jackie-Jiang commented on a change in pull request #7896:
URL: https://github.com/apache/pinot/pull/7896#discussion_r768263597
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
##########
@@ -935,14 +939,9 @@ protected boolean commitSegment(String controllerVipUrl,
boolean isSplitCommit)
return segmentCommitter.commit(_segmentBuildDescriptor);
}
- protected boolean buildSegmentAndReplace() {
+ protected void buildSegmentAndReplace() throws Exception {
SegmentBuildDescriptor descriptor = buildSegmentInternal(false);
Review comment:
Sorry I missed that. When we throw the exception, we should not log the
error. The catcher is responsible for logging the error, or we will log
multiple errors for the same exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
