richardstartin commented on a change in pull request #7885: URL: https://github.com/apache/pinot/pull/7885#discussion_r768625404
########## File path: pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/TextIndexCreatorProvider.java ########## @@ -0,0 +1,47 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.spi.creator; + +import java.io.IOException; +import org.apache.pinot.segment.spi.index.creator.TextIndexCreator; + + +public interface TextIndexCreatorProvider { + /** + * Creates a {@see TextIndexCreator} from information about index creation. + * This allows a plugin to pattern match index creation information to select + * an appropriate implementation. + * @param context context about the index creation. + * @return a {@see ForwardIndexCreator} + * @throws IOException whenever something goes wrong matching or constructing the creator + */ + TextIndexCreator newTextIndexCreator(IndexCreationContext context) Review comment: Not really, not without adding more information to `IndexCreatorContext` because of the way it has been purposefully kept separate, which has rippled into the configuration layer. What I think would make sense is not to allow overriding of the Lucene based text index at all (it's also awkward to do for the reader), and leave it completely untouched by this change. At some point in the future we can make a decision about whether and how to migrate the first incarnation of text index to the FST indexes, but leave this distinction out of this SPI for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
