richardstartin commented on a change in pull request #7885:
URL: https://github.com/apache/pinot/pull/7885#discussion_r770079177



##########
File path: 
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/invertedindex/InvertedIndexHandler.java
##########
@@ -100,9 +104,8 @@ private void createInvertedIndexForColumn(ColumnMetadata 
columnMetadata)
     // Create new inverted index for the column.
     LOGGER.info("Creating new inverted index for segment: {}, column: {}", 
segmentName, column);
     int numDocs = columnMetadata.getTotalDocs();
-    try (OffHeapBitmapInvertedIndexCreator creator = new 
OffHeapBitmapInvertedIndexCreator(_indexDir,
-        columnMetadata.getFieldSpec(), columnMetadata.getCardinality(), 
numDocs,
-        columnMetadata.getTotalNumberOfEntries())) {
+    try (DictionaryBasedInvertedIndexCreator creator = 
_indexCreatorProvider.newInvertedIndexCreator(

Review comment:
       the default value is false




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to