klsince commented on pull request #8035: URL: https://github.com/apache/pinot/pull/8035#issuecomment-1016078054
> lgtm! Just want to check that you've confirmed this - will the failing fast in `needPreprocess` have any other side effects on the segment build process (such as incomplete cleanup). I think not, but just checking. The `needPreprocess` is wrapped in try-catch block that also wraps the the segment preprocessing. And cleanup happens in the catch block. The new changes would make it fail faster upon unsupported operations, saving some cost. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
